Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOSIP-38274: Resolved the bugs. #1061

Merged
merged 2 commits into from
Jan 2, 2025
Merged

MOSIP-38274: Resolved the bugs. #1061

merged 2 commits into from
Jan 2, 2025

Conversation

Anil-kumar-Majji
Copy link

@Anil-kumar-Majji Anil-kumar-Majji commented Dec 24, 2024 •
edited
Loading

In the Above PR, I have sanitized the whole app and fixed the issues wherever I found related to:

  1. Tab key actions,
  2. Missing IDs for the Elements.
  3. Text Sizes.
  4. If any Firefox browser Errors
  5. If any translation errors can be seen throughout the app.

SwethaKrish4
SwethaKrish4 suggested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@SwethaKrish4 SwethaKrish4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. remove id in mosip icon and add id for hamburger icon
  2. remove id for side_menu_title, root_trust_details_certificate_label, confirmation_success_icon, deActive_popup_headerMsg, columnheaderName, rectangleGrid,
    error_popup, loading_icon and success_msg

@mayuradesh mayuradesh merged commit 1975952 into mosip:develop Jan 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwethaKrish4 SwethaKrish4 SwethaKrish4 requested changes

@mayuradesh mayuradesh mayuradesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anil-kumar-Majji @mayuradesh @SwethaKrish4