-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On click of Download card, If the internet if Off Display no internet connection page #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatigoel
requested changes
Oct 10, 2023
swatigoel
approved these changes
Oct 10, 2023
Anil-kumar-Majji
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Oct 10, 2023
… connection page (mosip#903) * feat(INJI-413): add internet connection off page on click of download card button * feat(INJI-357): refactor the error component to render modal or view * feat(INJI-357): add error message translation for all languages --------- Co-authored-by: Pooja Babusingh <[email protected]> Signed-off-by: anil_majji <[email protected]>
swatigoel
pushed a commit
that referenced
this pull request
Oct 10, 2023
* On click of Download card, If the internet if Off Display no internet connection page (#903) * feat(INJI-413): add internet connection off page on click of download card button * feat(INJI-357): refactor the error component to render modal or view * feat(INJI-357): add error message translation for all languages --------- Co-authored-by: Pooja Babusingh <[email protected]> Signed-off-by: anil_majji <[email protected]> * Activation status adjusted in folded device UI of Vc-Item Signed-off-by: anil_majji <[email protected]> * fix(INJI-268)- Adjusted alignment of headers to center Signed-off-by: anil_majji <[email protected]> * Modified vertical line in Purple Theme Signed-off-by: anil_majji <[email protected]> --------- Signed-off-by: anil_majji <[email protected]> Co-authored-by: PoojaBabusing <[email protected]> Co-authored-by: Pooja Babusingh <[email protected]>
swatigoel
pushed a commit
that referenced
this pull request
Oct 11, 2023
…rens due to header alignment (#913) * On click of Download card, If the internet if Off Display no internet connection page (#903) * feat(INJI-413): add internet connection off page on click of download card button * feat(INJI-357): refactor the error component to render modal or view * feat(INJI-357): add error message translation for all languages --------- Co-authored-by: Pooja Babusingh <[email protected]> Signed-off-by: anil_majji <[email protected]> * Activation status adjusted in folded device UI of Vc-Item Signed-off-by: anil_majji <[email protected]> * fix(INJI-268)- Adjusted alignment of headers to center Signed-off-by: anil_majji <[email protected]> * Modified vertical line in Purple Theme Signed-off-by: anil_majji <[email protected]> * fix(INJI-268): Resolved the back buttons issue in Settings & About Screns due to header alignment Signed-off-by: anil_majji <[email protected]> --------- Signed-off-by: anil_majji <[email protected]> Co-authored-by: PoojaBabusing <[email protected]> Co-authored-by: Pooja Babusingh <[email protected]>
Anil-kumar-Majji
added a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Oct 11, 2023
…rens due to header alignment (mosip#913) * On click of Download card, If the internet if Off Display no internet connection page (mosip#903) * feat(INJI-413): add internet connection off page on click of download card button * feat(INJI-357): refactor the error component to render modal or view * feat(INJI-357): add error message translation for all languages --------- Co-authored-by: Pooja Babusingh <[email protected]> Signed-off-by: anil_majji <[email protected]> * Activation status adjusted in folded device UI of Vc-Item Signed-off-by: anil_majji <[email protected]> * fix(INJI-268)- Adjusted alignment of headers to center Signed-off-by: anil_majji <[email protected]> * Modified vertical line in Purple Theme Signed-off-by: anil_majji <[email protected]> * fix(INJI-268): Resolved the back buttons issue in Settings & About Screns due to header alignment Signed-off-by: anil_majji <[email protected]> --------- Signed-off-by: anil_majji <[email protected]> Co-authored-by: PoojaBabusing <[email protected]> Co-authored-by: Pooja Babusingh <[email protected]> Signed-off-by: anil_majji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the issue: https://mosip.atlassian.net/browse/INJI-357