feat(INJI-503): add configurable issuer details #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kiruthika Jeyashankar <[email protected]>
Signed-off-by: Kiruthika Jeyashankar <[email protected]>
swatigoel
reviewed
Nov 30, 2023
| function getIssuerLogo() { | ||
| return {uri: props.logoUrl}; | ||
| return {uri: props.displayDetails.logo.url}; |
There was a problem hiding this comment.
should we take care of optional in case it happens in future when we fetch data direct from well-known env not from controlled env.
prop. displayDetails?.logo?.url
There was a problem hiding this comment.
Can we make logo as optional when we bring in well-know change?
Because As of now , this type matches our current structure + when we bring in well-know change we should be changing some props to say if wellKnownLogo available take it or else do something. so can we keep it this way for now @swatigoel ?
Signed-off-by: Kiruthika Jeyashankar <[email protected]>
swatigoel
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.