[INJIVER-587] - OVP Backend #239

sree96 · 2024-11-26T14:32:25Z

No description provided.

Signed-off-by: Sreenadh S <[email protected]>

pom.xml

verify-core/.mvn/wrapper/maven-wrapper.properties

verify-core/pom.xml

...c/main/java/io/mosip/verifyservice/services/VerifiablePresentationSubmissionServiceImpl.java

vishwa-vyom · 2024-12-09T13:16:03Z

.../src/main/java/io/mosip/verifyservice/services/VerifiablePresentationRequestServiceImpl.java

+    public AuthorizationRequestCreateResponseDto createAuthorizationRequest(AuthorizationRequestCreateDto vpRequestCreate) {
+
+        String transactionId = vpRequestCreate.getTransactionId()!=null ? vpRequestCreate.getTransactionId() : Utils.createID(Constants.TRANSACTION_ID_PREFIX);
+        String requestId = Utils.createID(Constants.REQUEST_ID_PREFIX);


For the same transaction, if vp-request endpoint is called multiple times, we don't restricts ? How will you know which request id submission should be considered ?

submission is based on req-id which is unique and there can be only one submission at a time

the questions is what happens when the create authorization request is called multiple times ?
Will it create a new request id, when the old request id is still valid ?

Each time it will create a new req_id.

All the req_id is still valid because it represents a new transaction every time.

Its the verify FE tries to submit for latest req_id.

...c/main/java/io/mosip/verifyservice/services/VerifiablePresentationSubmissionServiceImpl.java

Signed-off-by: Sreenadh S <[email protected]>

vishwa-vyom · 2024-12-10T01:06:44Z

Also unit test case files were missing this PR

Signed-off-by: Sreenadh S <[email protected]>

vishwa-vyom · 2024-12-23T01:55:04Z

verify-service/src/main/java/io/inji/verify/dto/authorizationRequest/StatusDto.java

+@NoArgsConstructor
+@AllArgsConstructor
+public class StatusDto {
+    SubmissionState status;


/{requestId}/status - SubmissionState status; - is little confusing since the request is expecting a request status and the status dto has a enum called SubmissionState and the field name is status.

Lets just send the status alone as a response then. That makes more sense right.

As discusssed, lets have separate enums from VPRequestStatus and VPResultStatus and lets construct a proper json response only with status field when responding from vp request status API.

I think we discussed about removing COMPLETED and change to something like VP_SUBMITTED / VP_RECEIVED

...rc/main/java/io/mosip/verifycore/dto/authorizationRequest/AuthorizationRequestCreateDto.java

vishwa-vyom · 2024-12-23T02:00:01Z

verify-service/src/main/java/io/inji/verify/controller/VPSubmissionController.java

+    @Autowired
+    GsonSingleton gsonSingleton;
+
+    @GetMapping(path = "/vp-result/{transactionId}")


Does is this fit inside this controller ?
As per the API categorization it was under VP request management, we should revisit this.

I think we discussed to keep the result part as different controller right ? because of the exposure to internet vs protected endpoint

...e/src/main/java/io/inji/verify/dto/authorizationRequest/AuthorizationRequestResponseDto.java

verify-service/src/main/java/io/mosip/verifyservice/controller/VpSubmissionController.java

Signed-off-by: Sreenadh S <[email protected]>

sree96 force-pushed the injiver-587-ovp-endpoints branch 3 times, most recently from 7e1cbcb to db67f41 Compare November 27, 2024 04:40

sree96 requested a review from swatigoel November 27, 2024 04:42

sree96 force-pushed the injiver-587-ovp-endpoints branch from 5c3b25d to 32174f8 Compare November 27, 2024 10:00

sree96 added 13 commits December 2, 2024 12:20

[INJIVER-587] - add auth request creation API

fb9f72a

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - Add presentattion APIs

99d9fe3

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - Add presentattion submission APIs

63ca2b3

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - correcting expiry condition

66f9586

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - refactoring

fc8ebb4

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - refactoring

f48e38e

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - return verification status with result

94aacf5

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - generate nonce if not ptovided

456e8bd

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - status update

1c95a40

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - status update

be55461

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - code cleanup

be7317c

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - code cleanup

c3c62d9

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - add auto timer for setting expiry

c8a582c

Signed-off-by: Sreenadh S <[email protected]>

sree96 force-pushed the injiver-587-ovp-endpoints branch from 32174f8 to c8a582c Compare December 2, 2024 06:51

sree96 added 2 commits December 2, 2024 13:03

[INJIVER-587] - move sumbission process to a different thread

160c719

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - results now sending along with status

a1b533e

Signed-off-by: Sreenadh S <[email protected]>

sree96 requested a review from vishwa-vyom December 6, 2024 06:50

vishwa-vyom requested changes Dec 9, 2024

View reviewed changes

[INJIVER-587] - add pom descriptions

dc43eb0

Signed-off-by: Sreenadh S <[email protected]>

sree96 added 5 commits December 10, 2024 11:04

[INJIVER-587] - remove unused filed for now

4a7c94f

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - use lombok constructor

f81ae26

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - rename DTOs based on API docs

cfff175

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - rename iat to issuedAt

3995fb1

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - rename all Vp to VP and Vc to VC

4b2450d

Signed-off-by: Sreenadh S <[email protected]>

sree96 added 5 commits December 11, 2024 11:44

[INJIVER-587] - add unit test

26a1563

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - add unit test

2118056

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - remove mvn wrapper

2d4714d

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - merge core to service and rename group id

2400a58

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - rename package

663470a

Signed-off-by: Sreenadh S <[email protected]>

sree96 force-pushed the injiver-587-ovp-endpoints branch from 5a7bbc6 to 663470a Compare December 11, 2024 11:52

sree96 added 7 commits December 13, 2024 12:12

[INJIVER-587] - remove state ana use dynamic calculation

2019970

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - rename tables

040a196

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - ignore null values in DTO

93718fc

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - ignore null values in DTO

fb2f8d1

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - remove thread

ca0ae6c

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - remove thread

45ea8b0

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - add base64 decode for pem string

e6bf2aa

Signed-off-by: Sreenadh S <[email protected]>

vishwa-vyom reviewed Dec 23, 2024

View reviewed changes

sree96 added 15 commits December 23, 2024 09:45

[INJIVEr-587] - test fix

1e1c22d

Signed-off-by: Sreenadh S <[email protected]>

[INJIVEr-587] - refactoring

df761e2

Signed-off-by: Sreenadh S <[email protected]>

[INJIVEr-587] - refactoring

065747e

Signed-off-by: Sreenadh S <[email protected]>

[INJIVEr-587] - only sending status now

20eea82

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - refactoring

fdb3c18

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - refactor logic of getting latest submission

10fa0df

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - refactor naming for contrillers and services

115181d

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - refactor to bean singleton approach

446d523

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - refactored

0503fc1

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - refactored

412bfa3

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - refactored

c971ea6

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - send error also while getting result

efcb7d7

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - renamed state

da42c40

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - move vp-result to different controller

9906bdb

Signed-off-by: Sreenadh S <[email protected]>

[INJIVER-587] - do not save the PD sent

006221b

Signed-off-by: Sreenadh S <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[INJIVER-587] - OVP Backend #239

[INJIVER-587] - OVP Backend #239

sree96 commented Nov 26, 2024

vishwa-vyom Dec 9, 2024

sree96 Dec 17, 2024

vishwa-vyom Dec 23, 2024

sree96 Dec 23, 2024

vishwa-vyom Dec 24, 2024

vishwa-vyom commented Dec 10, 2024

vishwa-vyom Dec 23, 2024

sree96 Dec 23, 2024

vishwa-vyom Dec 23, 2024

vishwa-vyom Dec 24, 2024

vishwa-vyom Dec 23, 2024

vishwa-vyom Dec 24, 2024

[INJIVER-587] - OVP Backend #239

Are you sure you want to change the base?

[INJIVER-587] - OVP Backend #239

Conversation

sree96 commented Nov 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vishwa-vyom commented Dec 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment