Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero bias conversion corrected #624

Merged
merged 4 commits into from
Jan 4, 2024
Merged

zero bias conversion corrected #624

merged 4 commits into from
Jan 4, 2024

Conversation

megha95
Copy link
Contributor

@megha95 megha95 commented Sep 23, 2023

modified checkpoint_conversion_helpers.py: Biases were getting forcefully saved in fp32, corrected it by passing numpy data type in the functions.

@megha95 megha95 requested a review from dskhudia September 23, 2023 01:30
@irenedea
Copy link
Contributor

irenedea commented Jan 3, 2024

@megha95 are you still planning to merge this?

@megha95
Copy link
Contributor Author

megha95 commented Jan 4, 2024

@irenedea This code is not used currently in any workflow so this got delayed. But merged it regardless in case of future use.

@megha95 megha95 merged commit 44fe631 into main Jan 4, 2024
10 checks passed
@dakinggg dakinggg deleted the hf_to_ft_convert_fix2 branch March 14, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants