Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non existent named arguments to StreamingDataset #621

Closed
wants to merge 1 commit into from
Closed

Remove non existent named arguments to StreamingDataset #621

wants to merge 1 commit into from

Conversation

irenedea
Copy link
Contributor

Fixes the following pyright failures:

  /Users/irene.dea/llm-foundry/llmfoundry/data/text_data.py:150:13 - error: No parameter named "sampling_granularity" (reportGeneralTypeIssues)
  /Users/irene.dea/llm-foundry/llmfoundry/data/text_data.py:151:13 - error: No parameter named "batching_method" (reportGeneralTypeIssues)
/Users/irene.dea/llm-foundry/llmfoundry/data/finetuning/tasks.py
  /Users/irene.dea/llm-foundry/llmfoundry/data/finetuning/tasks.py:179:13 - error: No parameter named "sampling_granularity" (reportGeneralTypeIssues)
  /Users/irene.dea/llm-foundry/llmfoundry/data/finetuning/tasks.py:180:13 - error: No parameter named "batching_method" (reportGeneralTypeIssues)

karan6181
karan6181 reviewed Sep 25, 2023
View reviewed changes
llmfoundry/data/finetuning/tasks.py
@@ -176,8 +176,6 @@ def __init__(self,
shuffle_seed=shuffle_seed,
shuffle_block_size=shuffle_block_size,
sampling_method=sampling_method,
sampling_granularity=sampling_granularity,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are valid arguments based on streaming 0.6.0 release: link. Are you using older streaming version ?

dakinggg
dakinggg requested changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe if you update your local streaming version these will go away. (since CI passes)

@irenedea
Copy link
Contributor Author

oh shoot, yes updating locally passes, thanks!! @karan6181 @dakinggg

@irenedea irenedea closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karan6181 karan6181 karan6181 left review comments

@dakinggg dakinggg dakinggg requested changes

@snarayan21 snarayan21 Awaiting requested review from snarayan21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irenedea @karan6181 @dakinggg