Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eval yamls #609

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix eval yamls #609

merged 3 commits into from
Sep 20, 2023

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Sep 18, 2023 •
edited
Loading

Fixes some issues in eval yamls

Manual Testing

Here are the completed eval runs with no errors:

  • mpt-eval-xFtLW5
  • hf-eval-stwFhv
  • hf-8bit-eval-206Zp5
  • hf-lora-eval-JHvNUf

@irenedea irenedea requested a review from dakinggg September 18, 2023 22:35
@irenedea irenedea marked this pull request as ready for review September 18, 2023 22:35
dakinggg
dakinggg reviewed Sep 18, 2023
View reviewed changes
scripts/eval/yamls/hf_lora_eval.yml Outdated Show resolved Hide resolved
scripts/eval/yamls/mpt_eval.yaml Show resolved Hide resolved
@irenedea irenedea force-pushed the eval-fixes branch 2 times, most recently from 8d1d111 to 0ecba38 Compare September 19, 2023 21:01
@irenedea irenedea requested a review from dakinggg September 19, 2023 21:03
@irenedea irenedea enabled auto-merge (squash) September 20, 2023 02:26
@irenedea irenedea merged commit 9cf375e into mosaicml:main Sep 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irenedea @dakinggg