Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding preprocessors for QA and messages datasets #1700

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Adding preprocessors for QA and messages datasets #1700

merged 7 commits into from
Dec 17, 2024

Conversation

ShashankMosaicML
Copy link
Contributor

No description provided.

@ShashankMosaicML ShashankMosaicML marked this pull request as ready for review December 17, 2024 05:14
@ShashankMosaicML ShashankMosaicML requested a review from a team as a code owner December 17, 2024 05:14
gupta-abhay
gupta-abhay approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@gupta-abhay gupta-abhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dakinggg
dakinggg approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a quick unit test for each of the functions you added please? Approving preemptively because code lgtm, but please do that. don't need to test e2e, just unit test for the functions you're adding (input some dict, outputs the right dict)

@ShashankMosaicML
Copy link
Contributor Author

Could you add a quick unit test for each of the functions you added please? Approving preemptively because code lgtm, but please do that. don't need to test e2e, just unit test for the functions you're adding (input some dict, outputs the right dict)

Done!

@ShashankMosaicML ShashankMosaicML enabled auto-merge (squash) December 17, 2024 19:38
@ShashankMosaicML ShashankMosaicML merged commit 3269c73 into mosaicml:main Dec 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@gupta-abhay gupta-abhay gupta-abhay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShashankMosaicML @gupta-abhay @dakinggg