Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DistributedSampler RNG seed argument #1677

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

janEbert
Copy link
Contributor

Relies on mosaicml/composer#3724.

Closes #1676.

@janEbert janEbert requested a review from a team as a code owner November 28, 2024 10:26
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mvpatel2000
Copy link
Collaborator

Note that tests will fail until Composer bump CC: @dakinggg to track

@janEbert
Copy link
Contributor Author

I guess we need to update the requirement in setup.py accordingly? Forgot about that.

@dakinggg
Copy link
Collaborator

dakinggg commented Dec 2, 2024

Yeah unfortunately it won't work until we have the necessary code in a Composer release and then update Foundry. You can of course install from branches to unblock yourself as needed.

Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself lgtm though

@snarayan21
Copy link
Contributor

Composer v0.28.0 has been released and dependency updated. Rerunning CI/CD

@snarayan21 snarayan21 merged commit ff3d901 into mosaicml:main Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finetuning dataloader does not respect shuffle seed
4 participants