Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use allenai/c4 instead of c4 dataset #1554

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Use allenai/c4 instead of c4 dataset #1554

merged 3 commits into from
Sep 26, 2024

Conversation

eitanturok
Copy link
Contributor

@eitanturok eitanturok commented Sep 26, 2024 •
edited
Loading

HuggingFace has deprecated the c4 dataset and recommends using allenai/c4 dataset.

See the warning in a recent github workflow here.

This is a cleaner version of this PR.

@eitanturok eitanturok requested a review from a team as a code owner September 26, 2024 18:44
mvpatel2000
mvpatel2000 reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM onc etests pass

dakinggg
dakinggg reviewed Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run the quickstart, which uses c4, and make sure it still runs please?

@eitanturok eitanturok requested a review from a team as a code owner September 26, 2024 20:59
@eitanturok
Copy link
Contributor Author

I updated all of the docs, README, and yamls to use allenai/c4.

@dakinggg I ran the quickstart with the updated commands, and it all works!

@eitanturok eitanturok requested a review from dakinggg September 26, 2024 21:01
@eitanturok eitanturok merged commit 3b1fc4a into mosaicml:main Sep 26, 2024
9 checks passed
@eitanturok eitanturok deleted the allenai-c4 branch September 26, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 left review comments

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eitanturok @mvpatel2000 @dakinggg