Sort callbacks so that CheckpointSaver goes before HuggingFaceCheckpointer #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvpatel2000 What tests would you like to see? I can add a test for the helper function that checks to see that the callbacks are in the expected order. Anything else? |
I think that's fine! |
irenedea
force-pushed
the
reorder-callbacks
branch
from
2ee540f to
898812d
Compare
mvpatel2000
approved these changes
Sep 9, 2024
irenedea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort the callbacks so CheckpointSaver goes before HuggingFaceCheckpointer . This saves time during final checkpoint saving and uploading.
A rough sketch on the reordering based on Llama 70B profiling:
Before
After
e2e run in staging:
ift-meta-llama-3-8b-aoprwt-reordered-q01HKT