Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI tests to v0.1.2 #1466

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Update CI tests to v0.1.2 #1466

merged 5 commits into from
Aug 19, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Aug 19, 2024

We were calling uses: mosaicml/ci-testing/.github/actions/[email protected] which depends on having scripts in ci-testing ref v0.1.2, which are not in v0.1.0, causing directory not found.

@KuuCi
Copy link
Contributor Author

KuuCi commented Aug 19, 2024

For manual test, we set pull_request_target to pull_request: https://github.com/mosaicml/llm-foundry/actions/runs/10459273593/job/28962904068?pr=1466

@KuuCi KuuCi marked this pull request as ready for review August 19, 2024 19:52
@KuuCi KuuCi requested a review from a team as a code owner August 19, 2024 19:52
@KuuCi KuuCi requested review from dakinggg and mvpatel2000 August 19, 2024 19:52
@KuuCi
Copy link
Contributor Author

KuuCi commented Aug 19, 2024

Failing because updating CI tests, refer to manual test above for proof of it working

@dakinggg dakinggg merged commit c3a9637 into main Aug 19, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants