Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user error for UnicodeDeocdeError in convert text to mds #1457

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Add user error for UnicodeDeocdeError in convert text to mds #1457

merged 2 commits into from
Aug 16, 2024

Conversation

irenedea
Copy link
Contributor

Addresses the following error:

for chunk in iter(partial(f.read, 1000000), ''):
  File "<frozen codecs>", line 322, in decode
[2024-08-15 15:09:09.939000+00:00][15086]: UnicodeDecodeError: 'utf-8' codec can't decode byte 0x95 in position 203337:

@irenedea irenedea requested a review from a team as a code owner August 15, 2024 22:42
@irenedea irenedea requested a review from jjanezhang August 15, 2024 22:42
dakinggg
dakinggg approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@irenedea
Copy link
Contributor Author

@dakinggg added!
8233d86

@irenedea irenedea enabled auto-merge (squash) August 16, 2024 20:18
@irenedea irenedea merged commit ddccd12 into mosaicml:main Aug 16, 2024
9 checks passed
@mattyding mattyding mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@jjanezhang jjanezhang Awaiting requested review from jjanezhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irenedea @dakinggg