Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled generalizing build_inner_model in ComposerHFCausalLM #1450

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Enabled generalizing build_inner_model in ComposerHFCausalLM #1450

merged 6 commits into from
Aug 13, 2024

Conversation

gupta-abhay
Copy link
Contributor

  • Will allow the static function to be called externally
    • Users can now use this function (instead of re-writing it for all transformer classes)
    • Can call hyper-specfic function classes as well.

@gupta-abhay gupta-abhay requested a review from a team as a code owner August 13, 2024 17:33
dakinggg
dakinggg reviewed Aug 13, 2024
View reviewed changes
llmfoundry/models/hf/hf_causal_lm.py Outdated Show resolved Hide resolved
llmfoundry/models/hf/hf_causal_lm.py Outdated Show resolved Hide resolved
dakinggg
dakinggg reviewed Aug 13, 2024
View reviewed changes
llmfoundry/models/hf/hf_causal_lm.py Outdated Show resolved Hide resolved
llmfoundry/models/hf/hf_causal_lm.py Outdated Show resolved Hide resolved
dakinggg
dakinggg approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title to reflect the actual changes before merging

@gupta-abhay gupta-abhay changed the title Small change Enabled model_class for generalizing build_inner_model in ComposerHFCausalLM Aug 13, 2024
@gupta-abhay gupta-abhay changed the title Enabled model_class for generalizing build_inner_model in ComposerHFCausalLM Enabled generalizing build_inner_model in ComposerHFCausalLM Aug 13, 2024
@gupta-abhay gupta-abhay merged commit 67f1498 into main Aug 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gupta-abhay @dakinggg