Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flash patching for HF #1436

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Remove flash patching for HF #1436

merged 4 commits into from
Aug 7, 2024

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Aug 7, 2024

HF has fixed the bugs that required the monkeypatching, so we can remove it now.

Manual test that loss, throughput, and memory are the same before and after
Screenshot 2024-08-07 at 12 45 38 PM
Screenshot 2024-08-07 at 12 45 47 PM
Screenshot 2024-08-07 at 12 45 57 PM

@dakinggg dakinggg marked this pull request as ready for review August 7, 2024 19:47
@dakinggg dakinggg requested a review from a team as a code owner August 7, 2024 19:47
@dakinggg dakinggg requested a review from irenedea August 7, 2024 19:47
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarification comment on test, probably my misunderstanding. other than that, lgtm!

always hype to remove patches

tests/models/hf/test_hf_config.py Show resolved Hide resolved
@dakinggg dakinggg merged commit c262341 into mosaicml:main Aug 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants