Fix log_config #1432
Merged
Fix log_config #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snarayan21
reviewed
Aug 6, 2024
There was a problem hiding this comment.
looks fine to me, given the changes around config logging would also like @b-chu to approve before merging.
Could you do a simple manual run off this branch to show the functionality working fine?
b-chu
reviewed
Aug 7, 2024
There was a problem hiding this comment.
Breaks BC, but I'll let @snarayan21 approve. Do you have a screenshot of wandb and mlflow before and after this change?
|
Disabling automerge because I want to see how logging UI changed. Feel free to merge after posting
|
|
@josejg merge whenever you're ready |
snarayan21
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundry's train and eval scripts use the
log_confighelper to log the parameter config. However,log_configbreaks the logger abstraction by directly logging to wandb and/or mlflow.This PR uses the
logger.log_hyperparametermethod which relies on the same method calls for wandb and mlflow. In addition this PR allows custom loggers to be able to log the config which is not currently supported.EDIT: Run Name
210m-tpr100-adam-cool-linear-lr2d3-20pct-JvGeHi