-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transforms to logged config #1428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooh nice. can you include the run name for the manual test (and highlight the differences in the logged configs, if possible)?
thanks!!
logged_cfg before logged_cfg after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Failing from transient HF timeouts :( @snarayan21 PR also needs to update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, forgot the callbacks use the logged config. Thanks!
Uses the transformed version of the training config as the logged config. This is because we infer values like device_train_batch_size during transforms. The logged config is later used in callbacks like curriculum learning which should have access to all the data in TrainConfig.
Manual run to test that logged_cfg matches the train_cfg values from transforms and curriculum learning callback works.