Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pretrained model name correctly, if provided, in HF Checkpointer #1407

Merged
merged 7 commits into from
Jul 29, 2024
Merged

Set pretrained model name correctly, if provided, in HF Checkpointer #1407

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c61a14e
yo
snarayan21 Jul 29, 2024
10b1ea9
yo
snarayan21 Jul 29, 2024
b3b70fc
yo
snarayan21 Jul 29, 2024
4bb1dec
yo
snarayan21 Jul 29, 2024
1dc9642
Merge branch 'main' into saaketh/base_model_name
snarayan21 Jul 29, 2024
8805071
yo
snarayan21 Jul 29, 2024
84dcbfc
Merge branch 'saaketh/base_model_name' of github.com-me:mosaicml/llm-…
snarayan21 Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions llmfoundry/callbacks/hf_checkpointer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,14 @@ def __init__(
)

self.mlflow_logging_config = mlflow_logging_config
if 'metadata' in self.mlflow_logging_config:
self.pretrained_model_name = self.mlflow_logging_config[
'metadata'].get(
'pretrained_model_name',
None,
)
else:
self.pretrained_model_name = None

self.huggingface_folder_name_fstr = os.path.join(
'huggingface',
Expand Down Expand Up @@ -529,6 +537,16 @@ def tensor_hook(
original_tokenizer,
)

# Ensure that the pretrained model name is correctly set on the saved HF checkpoint.
if self.pretrained_model_name is not None:
new_model_instance.name_or_path = self.pretrained_model_name
if self.using_peft:
new_model_instance.base_model.name_or_path = self.pretrained_model_name
for k in new_model_instance.peft_config.keys():
new_model_instance.peft_config[
k
].base_model_name_or_path = self.pretrained_model_name

log.debug('Saving Hugging Face checkpoint to disk')
# This context manager casts the TE extra state in io.BytesIO format to tensor format
# Needed for proper hf ckpt saving.
Expand Down Expand Up @@ -624,10 +642,7 @@ def tensor_hook(
# Upload the license file generated by mlflow during the model saving.
license_filename = _maybe_get_license_filename(
local_save_path,
self.mlflow_logging_config['metadata'].get(
'pretrained_model_name',
None,
),
self.pretrained_model_name,
)
if license_filename is not None:
mlflow_logger._mlflow_client.log_artifact(
Expand Down
Loading