Propagate name_or_path
through HF Checkpointer
#1402
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure to propagate model
name_or_path
through HF checkpointer (similar to how we do for generation config).Note that since PretrainedConfig always has the attr
name_or_path
, we don't need to checkhasattr
. All instances of PreTrainedModel will havename_or_path
(which defaults to "").Note that if the
pretrained_model_name_or_path
is a local path thenname_or_path
will also be a local path. And so when saving out LoRA adapters, for example, the adapter_config.json will havebase_model_name_or_path
as the local path. This PR does not solve this problem. IMO we should add a new optional arg to ComposerHFCausalLM that's the true model name and propagate that through model transforms & HF checkpointer instead ofname_or_path
.