Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all transforms to train script #1300

Merged
merged 5 commits into from
Jun 23, 2024
Merged

Add all transforms to train script #1300

merged 5 commits into from
Jun 23, 2024

Conversation

dakinggg
Copy link
Collaborator

In #1290, I added a unit test for the all transform, but forgot to add it to train.py

Loss curve before and after, also verified the batch size calculations are done the same.
Screenshot 2024-06-22 at 1 52 11 PM

@dakinggg dakinggg marked this pull request as ready for review June 22, 2024 21:17
@dakinggg dakinggg requested a review from a team as a code owner June 22, 2024 21:17
@dakinggg dakinggg enabled auto-merge (squash) June 22, 2024 21:17
snarayan21
snarayan21 reviewed Jun 23, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question

scripts/train/train.py Show resolved Hide resolved
snarayan21
snarayan21 approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@dakinggg dakinggg merged commit 8b5a1bb into mosaicml:main Jun 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 approved these changes

@mvpatel2000 mvpatel2000 Awaiting requested review from mvpatel2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @snarayan21