Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing in lbl_process_group directly #1298

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Allow passing in lbl_process_group directly #1298

merged 7 commits into from
Jun 21, 2024

Conversation

dakinggg
Copy link
Collaborator

Allows ffn_config['lbl_process_group'] to be direct constructed instead of just using string mappings.

@dakinggg dakinggg requested a review from a team as a code owner June 21, 2024 18:24
snarayan21
snarayan21 reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one test, nice otherwise

tests/models/utils/test_config_moe_args.py Outdated Show resolved Hide resolved
@dakinggg dakinggg enabled auto-merge (squash) June 21, 2024 19:28
@dakinggg dakinggg merged commit 2196d07 into mosaicml:main Jun 21, 2024
11 checks passed
@dakinggg dakinggg deleted the allow-pg branch June 22, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snarayan21 snarayan21 snarayan21 approved these changes

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@ShashankMosaicML ShashankMosaicML Awaiting requested review from ShashankMosaicML

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @mvpatel2000 @snarayan21