Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grad accum typing #1296

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Fix grad accum typing #1296

merged 1 commit into from
Jun 21, 2024

Conversation

dakinggg
Copy link
Collaborator

Fixes the typing on the config. It wasn't causing any errors because its just for logging, but it was getting incorrectly cast to a string.

@dakinggg dakinggg requested a review from a team as a code owner June 21, 2024 05:42
@dakinggg dakinggg enabled auto-merge (squash) June 21, 2024 05:43
Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@dakinggg dakinggg merged commit e8ba9b7 into mosaicml:main Jun 21, 2024
10 of 11 checks passed
@dakinggg dakinggg deleted the ga-type branch June 22, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants