Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing logging exception through update run metadata #1292

Merged
merged 12 commits into from
Jul 9, 2024
Merged

Removing logging exception through update run metadata #1292

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2a773b6
removed logging exception
jjanezhang Jun 19, 2024
678a806
merged main
jjanezhang Jul 3, 2024
7a5153b
removed logger from runtime callback
jjanezhang Jul 8, 2024
04bff5c
format files
jjanezhang Jul 8, 2024
41469f6
Merge branch 'main' into jane/remove-logger-exception
jjanezhang Jul 8, 2024
a13e708
removed unused import
jjanezhang Jul 8, 2024
2ce0483
put os kill in finally
jjanezhang Jul 8, 2024
729fe96
moving timeout earlier for testing
jjanezhang Jul 8, 2024
e13e50e
test timeout without try catch
jjanezhang Jul 9, 2024
f223f55
added back try finally
jjanezhang Jul 9, 2024
0ccc918
removing runtime error
jjanezhang Jul 9, 2024
f506c37
removed test init
jjanezhang Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions scripts/train/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,7 @@ def main(cfg: DictConfig) -> Trainer:
train_cfg.device_train_batch_size,
)
except BaseContextualError as e:
if mosaicml_logger is not None:
e.location = TrainDataLoaderLocation
mosaicml_logger.log_exception(e)
e.location = TrainDataLoaderLocation
raise e

if mosaicml_logger is not None:
Expand Down Expand Up @@ -427,9 +425,7 @@ def main(cfg: DictConfig) -> Trainer:
if eval_gauntlet_callback is not None:
callbacks.append(eval_gauntlet_callback)
except BaseContextualError as e:
if mosaicml_logger is not None:
e.location = EvalDataLoaderLocation
mosaicml_logger.log_exception(e)
e.location = EvalDataLoaderLocation
jjanezhang marked this conversation as resolved.
Show resolved Hide resolved
raise e

if mosaicml_logger is not None:
Expand Down
Loading