Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit 2.3 nightlies #1127

Closed
wants to merge 1 commit into from
Closed

Permit 2.3 nightlies #1127

wants to merge 1 commit into from

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Apr 20, 2024 •
edited
Loading

Now that we have more frequent releases, I think we can allow for torch nightly versions on main. Releases should tighten the pin to released versions of torch.

@dakinggg dakinggg marked this pull request as ready for review April 20, 2024 04:08
@dakinggg dakinggg requested a review from a team as a code owner April 20, 2024 04:08
@dakinggg dakinggg requested a review from mvpatel2000 April 20, 2024 04:08
mvpatel2000
mvpatel2000 reviewed Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.3 comes out in a week, imo we should just wait and not do this. The risk is high of breaking given imminent release

@dakinggg
Copy link
Collaborator Author

Fair enough

@dakinggg dakinggg closed this Apr 20, 2024
@dakinggg dakinggg deleted the torch-nightly branch June 22, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @mvpatel2000