Fix HF checkpointer + mlflow bugs #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
commented
Apr 23, 2024
irenedea
reviewed
Apr 23, 2024
irenedea
approved these changes
Apr 23, 2024
mvpatel2000
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge case where an mlflow model would not be registered if the hf save interval was exactly the same as the total duration in batches and the max duration was specified in epochs.
Manual tests for chat and not chat (and deployed and checked that input example still works), both test the edge case:
dur-edge-case-chat-4-mztOoRdur-edge-case-pr-3-u5qIfuNote, there is now a scary exception in the mlflow model saving logs, but it is harmless. The deployment and input example still works.