precommit

mosaicml · Sep 27, 2023 · 6180466 · 6180466
1 parent d29fb57
commit 6180466
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/llmfoundry/utils/config_utils.py b/llmfoundry/utils/config_utils.py
@@ -162,5 +162,5 @@ def log_config(cfg: DictConfig) -> None:
             import mlflow
         except ImportError as e:
             raise e
-        # if mlflow.active_run():
-        #     mlflow.log_params(params=om.to_container(cfg, resolve=True))
+        if mlflow.active_run():
+            mlflow.log_params(params=om.to_container(cfg, resolve=True))
diff --git a/tests/test_hf_conversion_script.py b/tests/test_hf_conversion_script.py
@@ -189,7 +189,7 @@ def test_callback_inits_with_defaults():
 @pytest.mark.parametrize('log_to_mlflow', [True, False])
 def test_huggingface_conversion_callback(model: str, tmp_path: pathlib.Path,
                                          fsdp_state_dict_type: str,
-                                         log_to_mlflow: bool, monkeypatch):
+                                         log_to_mlflow: bool):
     delete_transformers_cache()
 
     dist.initialize_dist(get_device('gpu'))