Skip to content

Commit

Permalink
Fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
irenedea committed Sep 11, 2024
1 parent ecd539e commit 44d41da
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion llmfoundry/callbacks/hf_checkpointer.py
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,10 @@ def run_event(self, event: Event, state: State, logger: Logger) -> None:
self._save_checkpoint(
state,
logger,
register_to_mflow=is_last_batch,
register_to_mflow=(
self.mlflow_registered_model_name is not None and
is_last_batch
),
upload_to_save_folder=not (
self.final_register_only and is_last_batch
),
Expand Down
1 change: 1 addition & 0 deletions tests/a_scripts/inference/test_convert_composer_to_hf.py
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,7 @@ class MockSpawnProcess:
def __init__(self, target: Callable, kwargs: dict[str, Any]):
self.target = target
self.kwargs = kwargs
self.exitcode = 0

def start(self):
self.target(**self.kwargs)
Expand Down

0 comments on commit 44d41da

Please sign in to comment.