Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analytics logging to
MosaicMLLogger
#3106base: main
Are you sure you want to change the base?
Add analytics logging to
MosaicMLLogger
#3106Changes from 20 commits
f2e5537
87f3d09
55e738f
da1a179
e0b559d
44cb283
681e166
362f9ba
21cce59
be30004
77d2c25
82d771a
b9aa219
250cfff
d841895
67fd0d8
4a9da31
8a5d9df
b8032c5
bca595b
52db068
f44ac72
b499ab4
45b1f8b
06cd615
53ec76c
a08bc51
192fb4b
0c6439e
6abd957
f10e8a9
cee3876
11eb853
51a0dd0
59dea8f
5037ffb
ea2eabc
8c867bc
5753020
a51d5d9
1083ae6
25e3ceb
bf02105
3be10ed
ba907b7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some idea for utility of analytics on save interval? Nothing is coming to mind for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was requested in a Slack thread a while back. this included some less-helpful metrics (i.e.
num_workers
) so if it isn't useful i'll take it out. @dakingggThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i think just drop this one