-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive cards/notifications #834
base: prototypes/adaptive-cards
Are you sure you want to change the base?
Adaptive cards/notifications #834
Conversation
This is a good start however we need the notifications to appear outside of the web module. Could you extend the PR with this? |
Thanks :) Regarding the notifications appearing using ComposeUI, it would be done in a task by a member from the .NET team so the use case of making the notifications appear outside of the web module would be dealt in that PR. This PR is more regarding the styling of the cards to see how the cards can be styled for different types of notifications. |
examples/adaptive-cards/index.html
Outdated
</head> | ||
|
||
<body> | ||
<div id="container"></div> | ||
<script type="text/javascript" src="https://unpkg.com/markdown-it/dist/markdown-it.min.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CDNs can time out and be blocked on the firewall.
Could you change the consumption of markdown-it to be through an installed NPM package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, will do. Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not forget squashing your commits!
This is pull request to expand on the adaptive cards poc with notifications for success, error and information.