Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive cards/notifications #834

Open
wants to merge 14 commits into
base: prototypes/adaptive-cards
Choose a base branch
from

Conversation

Sanjuice
Copy link

This is pull request to expand on the adaptive cards poc with notifications for success, error and information.

@Sanjuice Sanjuice requested a review from a team as a code owner November 15, 2024 22:01
@ZKRobi ZKRobi added this to the Compose as a web container milestone Nov 18, 2024
@ZKRobi
Copy link
Contributor

ZKRobi commented Nov 18, 2024

This is a good start however we need the notifications to appear outside of the web module. Could you extend the PR with this?

examples/adaptive-cards/app.js Outdated Show resolved Hide resolved
examples/adaptive-cards/app.js Outdated Show resolved Hide resolved
@kruplm kruplm removed this from the Compose as a web container milestone Nov 19, 2024
@Sanjuice
Copy link
Author

This is a good start however we need the notifications to appear outside of the web module. Could you extend the PR with this?

Thanks :) Regarding the notifications appearing using ComposeUI, it would be done in a task by a member from the .NET team so the use case of making the notifications appear outside of the web module would be dealt in that PR. This PR is more regarding the styling of the cards to see how the cards can be styled for different types of notifications.

@Sanjuice Sanjuice requested a review from speed-y November 21, 2024 13:28
</head>

<body>
<div id="container"></div>
<script type="text/javascript" src="https://unpkg.com/markdown-it/dist/markdown-it.min.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CDNs can time out and be blocked on the firewall.
Could you change the consumption of markdown-it to be through an installed NPM package?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, will do. Thanks :)

@Sanjuice Sanjuice requested a review from kruplm December 5, 2024 20:31
Copy link
Contributor

@lilla28 lilla28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not forget squashing your commits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants