fix(delete-record): removing the ommitting of required parameters fro…

…m DELETE record (#16)
mooyoul · May 8, 2021 · af62caa · af62caa
1 parent dad80d1
commit af62caa
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 21 deletions.
diff --git a/lambda-packages/dns-validated-domain-identity-handler/src/record.ts b/lambda-packages/dns-validated-domain-identity-handler/src/record.ts
@@ -19,26 +19,16 @@ export class Record {
   ) {}
 
   public action(type: "CREATE" | "UPSERT" | "DELETE"): Change {
-    if (type === "DELETE") {
-      return {
-        Action: "DELETE",
-        ResourceRecordSet: {
-          Name: this.name,
-          Type: this.type,
-        },
-      };
-    } else {
-      return {
-        Action: type,
-        ResourceRecordSet: {
-          Name: this.name,
-          Type: this.type,
-          ResourceRecords: [{
-            Value: this.value,
-          }],
-          TTL: this.ttl,
-        },
-      };
-    }
+    return {
+      Action: type,
+      ResourceRecordSet: {
+        Name: this.name,
+        Type: this.type,
+        ResourceRecords: [{
+          Value: this.value,
+        }],
+        TTL: this.ttl,
+      },
+    };
   }
 }
diff --git a/lambda-packages/dns-validated-domain-identity-handler/test/record.test.ts b/lambda-packages/dns-validated-domain-identity-handler/test/record.test.ts
@@ -69,6 +69,10 @@ describe(Record.name, () => {
         ResourceRecordSet: {
           Name: "example.com",
           Type: "CNAME",
+          TTL: 1234,
+          ResourceRecords: [
+            { Value: "target.example.com" },
+          ],
         },
       });
     });

diff --git a/lambda-packages/dns-validated-domain-identity-handler/test/verifier.test.ts b/lambda-packages/dns-validated-domain-identity-handler/test/verifier.test.ts
@@ -179,6 +179,10 @@ describe(Verifier.name, () => {
             ResourceRecordSet: {
               Name: "_amazonses.example.com",
               Type: "TXT",
+              TTL: 1800,
+              ResourceRecords: [
+                { Value: "\"token\"" },
+              ],
             },
           }],
         },
@@ -395,18 +399,30 @@ describe(Verifier.name, () => {
             ResourceRecordSet: {
               Name: "foo._domainkey.example.com",
               Type: "CNAME",
+              TTL: 1800,
+              ResourceRecords: [
+                { Value: "foo.dkim.amazonses.com"},
+              ],
             },
           }, {
             Action: "DELETE",
             ResourceRecordSet: {
               Name: "bar._domainkey.example.com",
               Type: "CNAME",
+              TTL: 1800,
+              ResourceRecords: [
+                { Value: "bar.dkim.amazonses.com"},
+              ],
             },
           }, {
             Action: "DELETE",
             ResourceRecordSet: {
               Name: "baz._domainkey.example.com",
               Type: "CNAME",
+              TTL: 1800,
+              ResourceRecords: [
+                { Value: "baz.dkim.amazonses.com"},
+              ],
             },
           }],
         },