Keyboard.removeEvents() doesn't work #1083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eEvents is called, it will call removeEvent with the already parsed event type. We cannot call Keyboard.parse() inside of removeEvent because then we would be parsing an already parsed event type. I don't really like my fix, as it means that an argument to Keyboard.addEvent() is not a valid argument to Keyboard.removeEvent. I'm not sure what the best fix to this problem is, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyboard.addEvent calls parent() with a parsed event type. When removeEvents is called, it will call removeEvent with the already parsed event type. We cannot call Keyboard.parse() inside of removeEvent because then we would be parsing an already parsed event type.
I don't really like my fix, as it means that an argument to Keyboard.addEvent() is not a valid argument to Keyboard.removeEvent. I'm not sure what the best fix to this problem is, however.