Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pallet_pooled_staking to Dancelight #774

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tmpolaczyk
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

WASM runtime size check:

Compared to target branch

dancebox runtime: 1424 KB (no changes) ✅

flashbox runtime: 820 KB (no changes) ✅

dancelight runtime: 2136 KB (no changes) ✅

container chain template simple runtime: 1124 KB (no changes) ✅

container chain template frontier runtime: 1400 KB (no changes) ✅

The max_collators config item was being ignored in Dancelight before
this PR
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Coverage Report

(master)

@@                     Coverage Diff                      @@
##           master   tomasz-starlight-staking      +/-   ##
============================================================
- Coverage   64.57%                     64.46%   -0.11%     
+ Files         320                        321       +1     
+ Lines       55407                      55523     +116     
============================================================
+ Hits        35777                      35790      +13     
+ Misses      19630                      19733     +103     
Files Changed Coverage
/solo-chains/runtime/dancelight/src/lib.rs 65.83% (-0.38%)

Coverage generated Tue Dec 3 16:59:18 UTC 2024

@tmpolaczyk tmpolaczyk marked this pull request as ready for review December 3, 2024 16:14
@tmpolaczyk tmpolaczyk added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant