Add support for eth to starlight message passing #772
+150
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthDesai
added
B0-silent
WASM runtime size check:Compared to target branchdancebox runtime: 1424 KB (no changes) ✅ flashbox runtime: 820 KB (no changes) ✅ dancelight runtime: 2104 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master parth-add-support-for-eth-to-starlight-message-passing +/- ##
=========================================================================================
Coverage 64.57% 64.57% 0.00%
Files 320 320
Lines 55407 55407
=========================================================================================
Hits 35777 35777
Misses 19630 19630
|
tmpolaczyk
reviewed
Dec 2, 2024
| @@ -15,7 +15,7 @@ if [ -d "$relayer_root_dir" ]; | |||
| then | |||
| echo "Relayer seems to be already setup. Skipping git fetch" | |||
| else | |||
| git clone https://github.com/Snowfork/snowbridge $relayer_root_dir | |||
| git clone https://github.com/moondance-labs/snowbridge $relayer_root_dir | |||
There was a problem hiding this comment.
People who have already run this script need to remove the snowbridge folder, otherwise it will fail, as it will use the old remote. CI works?
There was a problem hiding this comment.
yes. They will need to remove the old folder. CI should work as we clean up the tmp folder there from what I understand.
tmpolaczyk
reviewed
Dec 2, 2024
| cat "$output_dir/contracts.json" | ||
| contract_output=$(cat "$output_dir/contracts.json") | ||
|
|
||
| echo "{ \"data\": $contract_output, \"ethereum_key\": \"$ethereum_key\" }" |
There was a problem hiding this comment.
Let's use jq? (untested)
Suggested change
| echo "{ \"data\": $contract_output, \"ethereum_key\": \"$ethereum_key\" }" | |
| jq --arg ethereum_key "$ethereum_key" '{data: ., ethereum_key: $ethereum_key}' "$output_dir/contracts.json" |
ParthDesai
force-pushed
the
parth-add-support-for-eth-to-starlight-message-passing
branch
from
a9d9d56
to
dca3c6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends the bridge e2e shell scripts to do following:
It also extends the typescript test:
//ExecutionRelayphrase so that relayer can send transaction.