Fix docker publishing with also workers #769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
B0-silent
WASM runtime size check:Compared to target branchdancebox runtime: 1424 KB (no changes) ✅ flashbox runtime: 820 KB (no changes) ✅ dancelight runtime: 2104 KB (no changes) ✅ container chain template simple runtime: 1124 KB (no changes) ✅ container chain template frontier runtime: 1400 KB (no changes) ✅ |
Coverage Report@@ Coverage Diff @@
## master girazoki-fix-docker-publishing +/- ##
=================================================================
Coverage 64.57% 64.57% 0.00%
Files 320 320
Lines 55407 55407
=================================================================
Hits 35777 35777
Misses 19630 19630
|
tmpolaczyk
reviewed
Dec 2, 2024
| wget "${{ env.BASE_URL }}/$VERSION/${{ matrix.image.file_name }}-znver3" -O build/${{ matrix.image.file_name }}-znver3 | ||
| wget "${{ env.BASE_URL }}/$VERSION/${{ matrix.image.file_name }}-execute-worker-skylake" -O build/${{ matrix.image.file_name }}-execute-worker-znver3 |
There was a problem hiding this comment.
Typo?
Suggested change
| wget "${{ env.BASE_URL }}/$VERSION/${{ matrix.image.file_name }}-execute-worker-skylake" -O build/${{ matrix.image.file_name }}-execute-worker-znver3 | |
| wget "${{ env.BASE_URL }}/$VERSION/${{ matrix.image.file_name }}-execute-worker-znver3" -O build/${{ matrix.image.file_name }}-execute-worker-znver3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the docker publishing to upload also the worker executables