Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dancekit to change ref to vec #661

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

tmpolaczyk
Copy link
Contributor

moondance-labs/dancekit#31

I need this to be able to use RelayChainInterface::prove_read to implement OrchestratorChainInterface::prove_read. Using &Vec as input argument is never correct, but we are forced to do it here.

Copy link
Contributor

Coverage Report

(master)

@@                    Coverage Diff                     @@
##           master   tomasz-dancekit-vec-ref     +/-   ##
==========================================================
  Coverage   66.49%                    66.49%   0.00%     
  Files         261                       261             
  Lines       45854                     45854             
==========================================================
  Hits        30490                     30490             
  Misses      15364                     15364             
Files Changed Coverage

Coverage generated Fri Aug 23 11:47:06 UTC 2024

@tmpolaczyk tmpolaczyk added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes labels Aug 23, 2024
@tmpolaczyk tmpolaczyk merged commit 0c524b0 into master Aug 23, 2024
41 of 43 checks passed
@tmpolaczyk tmpolaczyk deleted the tomasz-dancekit-vec-ref branch August 23, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit not-breaking Does not need to be mentioned in breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants