Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified foreign asset creator #4

Closed
wants to merge 2 commits into from

Conversation

girazoki
Copy link
Collaborator

@girazoki girazoki commented Dec 8, 2023

This PR proposes a pallet that is similar to the asset-manager from moonbeam but it is a simplified version of it. In this case, the foreign-asset-creator-pallet is only responsible for creating and maintaining an assetId<->ForeignAsset mapping to ease the following situations:

  • knowing which assetId to touch whenever we receive an XCM MultiAsset
  • knowing which MultiAsset to send when we are told to send a specific assetId to another chain

Important changes:

  • We allow the creator to decide an assetId instead of deriving it ourselves through some other mechanism. The main reason for having a custom derivation for the assetId was that one could find a collision with a smart contract on the precompile address, but I believe this case is very ethereum specific and could be addressed in different manners (for instance, by using a smaller assetId type)

  • No units per second, this if needed should be done in a different pallet

  • No local asset creation

@girazoki
Copy link
Collaborator Author

girazoki commented Dec 8, 2023

Proposing it to moonkit instead!

@girazoki girazoki closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant