More changes for Tanssi Data Preservers container chain spawning on assignment #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmpolaczyk
reviewed
Jul 16, 2024
|
|
||
| use super::*; | ||
|
|
||
| fn expected_container_chain_genesis_data() -> ContainerChainGenesisData<ConstU32<255>> { |
There was a problem hiding this comment.
Suggested change
| fn expected_container_chain_genesis_data() -> ContainerChainGenesisData<ConstU32<255>> { | |
| fn expected_container_chain_genesis_data() -> ContainerChainGenesisData { |
Why is the CI green when this shouldn't compile?
There was a problem hiding this comment.
Feature-gated json. Since locally tanssi compiles it seems this feature is not used?
There was a problem hiding this comment.
Probably that feature is enabled for build but disabled when running tests...
There was a problem hiding this comment.
I checked the CI script and we do the same as in the tanssi repo, so we will encounter this issue there as well, as long as there is some feature which is not enabled by default, our unit tests will not run 😕
I guess the easiest way to notice that is to check the generated coverage file
tmpolaczyk
approved these changes
Jul 16, 2024
nanocryk
added a commit
that referenced
this pull request
Jul 16, 2024
…ssignment (#26) * add new interface fn + move rpc interface to tanssi * remove unused fn in Tanssi * fmt * remove generic
girazoki
pushed a commit
that referenced
this pull request
Aug 1, 2024
…ssignment (#26) * add new interface fn + move rpc interface to tanssi * remove unused fn in Tanssi * fmt * remove generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of moondance-labs/tanssi#625
OrchestratorChainInterfaceto get rid of the need for a client+runtime apiOrchestratorChainInterfacewhich will be moved to Tanssi