Add phar integration tests #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that box requires php81 to work, no matter of that the generated packages can be executed with older PHP versions.
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
=========================================
Coverage 84.62% 84.62%
Complexity 694 694
=========================================
Files 74 74
Lines 2140 2140
=========================================
Hits 1811 1811
Misses 329 329 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
stronk7
force-pushed
the
add_phar_integration_tests
branch
from
dcfea34 to
6bb6432
Compare
It's enough to run the tests once per supported PHP version. Also, update the CHANGELOG to share about these new tests. Closes moodlehq#71
stronk7
force-pushed
the
add_phar_integration_tests
branch
from
6bb6432 to
67f9e7f
Compare
🧡 🧡 🧡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the last days, we have fixed a number of checks to work ok when using the
moodle-plugin-ci.pharalternative.Obviously, that's not covered with unit tests, so we need to add some integration tests, similar to the
bin/moodle-plugin-ciones, but using the PHAR instead.Here they are, we test them once for each PHP version supported, that should be enough.
Plus, we make the PHAR available as artifact in the GHA runs so people can download them from there (normally we only rebuild the PHAR for releases).
Ciao :-)