bin: Correctly handle spaces in basedir and other refinements. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes use of the Bash builtin extended test operator features to streamline the conditionals. * bin/moodle-docker-compose: Do not use literal '$' in the user messages. (dockercompose): Rename variable to ... (dockercompose_cmd): ... this, which is made an array, which eases correctly handling quoting. (filename): Quote. * bin/moodle-docker-wait-for-app (basedir): Quote. Chain the conditions inside the same extended test. * bin/moodle-docker-wait-for-db (basedir): Quote. Do not use literal '$' in the error message. Signed-off-by: Maxim Cournoyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes use of the Bash builtin extended test operator
features to streamline the conditionals.
(dockercompose): Rename variable to ...
(dockercompose_cmd): ... this, which is made an array, which eases
correctly handling quoting.
(filename): Quote.
conditions inside the same extended test.
'$' in the error message.
Signed-off-by: Maxim Cournoyer [email protected]