This is a good PR #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Problems and Bugs
- In
action.yml, the color field is missing - In
review.py, the requests method is misspelled asrequestsinstead ofrequests.post - In
review.py, theprintstatement is missing anat the end ofresponse.json()
Suggestions to Improve
- In
action.yml, add the color field - In
review.py, changerequeststorequests.post - In
review.py, add anto the end ofresponse.json()
Summary Response
This pull request has a few issues, including a missing color field in action.yml, a misspelled requests method in review.py, and a missing n at the end of response.json() in review.py. Suggestions to improve the pull request include adding the color field to action.yml, changing requests to requests.post in review.py, and adding a n to the end of response.json() in review.py.
mono-chrome
commented
Jan 13, 2023
| @@ -39,7 +39,7 @@ def get_review(): | |||
| top_p=1.0, | |||
| frequency_penalty=0.0, | |||
| presence_penalty=0.0 | |||
| ) | |||
| ) #this si bad | |||
There was a problem hiding this comment.
Done on purpose to see if it catches it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.