Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove useless condition #6916

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

thor-son
Copy link
Contributor

@thor-son thor-son commented Oct 6, 2023

When value is empty string, it's caught in empty check condition and return null.
So suggest removing useless condition.

$val = '';
var_dump(empty($val)); // true
var_dump($val == '');  // true

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2023

CLA assistant check
All committers have signed the CLA.

@asbiin asbiin merged commit 58a2e65 into monicahq:main Oct 8, 2023
11 checks passed
@asbiin
Copy link
Member

asbiin commented Oct 8, 2023

Thank you @thor-son

@github-actions
Copy link

🎉 This PR is included in version 5.0.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants