Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-274724 - readinessProbe: use human readable timestamps instead #1630

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

nammn
Copy link
Collaborator

@nammn nammn commented Oct 14, 2024

Summary:

Change usage of zap as described by the lib:

// You may change these by setting the appropriate fields in the returned
// object.
// For example, use the following to change the time encoding format:
//
//	cfg := zap.NewProductionEncoderConfig()
//	cfg.EncodeTime = zapcore.ISO8601TimeEncoder

@nammn nammn changed the title readinessProbe: use human readable timestamps instead CLOUDP-274724 - readinessProbe: use human readable timestamps instead Oct 14, 2024
Copy link
Collaborator

@lsierant lsierant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@nammn nammn merged commit 95f954d into master Oct 15, 2024
49 of 50 checks passed
@nammn nammn deleted the readiness-human branch October 15, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants