Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-204105 Conditionally run the upgrade hook #1513

Merged
merged 1 commit into from
Mar 28, 2024
Merged

CLOUDP-204105 Conditionally run the upgrade hook #1513

merged 1 commit into from
Mar 28, 2024

Conversation

slaskawi
Copy link
Contributor

@slaskawi slaskawi commented Mar 21, 2024 •
edited
Loading

Summary

This Pull Requests runs the upgrade hook only if it exists (and it doesn't in Static Architecture)

nammn
nammn approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@nammn nammn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to bump something in the release.json?

@slaskawi
Copy link
Contributor Author

@nammn No, no - it's fine as is.

@slaskawi slaskawi merged commit 9e32503 into master Mar 28, 2024
42 checks passed
@slaskawi slaskawi deleted the CLOUDP-204105-condidional-version-upgrade-hook branch March 28, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nammn nammn nammn approved these changes

@mircea-cosbuc mircea-cosbuc Awaiting requested review from mircea-cosbuc mircea-cosbuc is a code owner

@lsierant lsierant Awaiting requested review from lsierant lsierant is a code owner

@Julien-Ben Julien-Ben Awaiting requested review from Julien-Ben Julien-Ben is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaskawi @nammn