Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove use of deprecated Go APIs #1468

Merged
merged 1 commit into from
Jan 17, 2024
Merged

cleanup: remove use of deprecated Go APIs #1468

merged 1 commit into from
Jan 17, 2024

Conversation

irajdeep
Copy link
Contributor

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@irajdeep irajdeep marked this pull request as ready for review January 17, 2024 05:17
irajdeep
irajdeep commented Jan 17, 2024
View reviewed changes
controllers/replica_set_controller.go
return true
}
return false
return strings.Contains(overriddenImage, construct.OfficialMongodbEnterpriseServerImageName)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a small refactor (made part of this PR)

Julien-Ben
Julien-Ben approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@Julien-Ben Julien-Ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irajdeep irajdeep merged commit 8bde94b into master Jan 17, 2024
44 checks passed
@irajdeep irajdeep deleted the cleanup_deprecated_use branch January 17, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julien-Ben Julien-Ben Julien-Ben approved these changes

@mircea-cosbuc mircea-cosbuc Awaiting requested review from mircea-cosbuc mircea-cosbuc is a code owner

@lsierant lsierant Awaiting requested review from lsierant lsierant is a code owner

@slaskawi slaskawi Awaiting requested review from slaskawi

@nammn nammn Awaiting requested review from nammn nammn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irajdeep @Julien-Ben