Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default resource requirements for init-containers #1457

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

irajdeep
Copy link
Contributor

Related to #1443 - I couldn't reproduce the issue. But while I was at it:

  1. Added default resource requirements for init-containers.
  2. Added a sample to override resource requirement for init-containers.

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@irajdeep irajdeep force-pushed the init_container_override branch from 42e4733 to 8dbe40f Compare December 29, 2023 10:58
Copy link
Member

@mircea-cosbuc mircea-cosbuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irajdeep irajdeep merged commit af5f064 into master Dec 29, 2023
42 checks passed
@irajdeep irajdeep deleted the init_container_override branch December 29, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants