Local dev / documentation improvement #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irajdeep
commented
Nov 30, 2023
| @@ -48,7 +48,7 @@ test: generate fmt vet manifests ## Run unit tests | |||
| manager: generate fmt vet ## Build operator binary | |||
| go build -o bin/manager ./cmd/manager/main.go | |||
|
|
|||
| run: install install-rbac ## Run the operator against the configured Kubernetes cluster in ~/.kube/config | |||
| run: install ## Run the operator against the configured Kubernetes cluster in ~/.kube/config | |||
There was a problem hiding this comment.
make e2e - already installs rbac. So installing it here creates resource conflict error.
irajdeep
requested review from
mircea-cosbuc,
lsierant,
slaskawi,
nammn and
Julien-Ben
as code owners
nammn
approved these changes
Nov 30, 2023
| @@ -116,6 +116,7 @@ manifests: controller-gen ## Generate manifests e.g. CRD, RBAC etc. | |||
| # Run e2e tests locally using go build while also setting up a proxy in the shell to allow | |||
| # the test to run as if it were inside the cluster. This enables mongodb connectivity while running locally. | |||
| e2e-telepresence: cleanup-e2e install ## Run e2e tests locally using go build while also setting up a proxy e.g. make e2e-telepresence test=replica_set cleanup=true | |||
| export MDB_LOCAL_OPERATOR=true; \ | |||
There was a problem hiding this comment.
exporting this means we are expecting folks to run the test locally (go test) and that the operator runs locally as well. Maybe we should make a new target for this? Or maybe a comment is enough 🤔
There was a problem hiding this comment.
I think leaving a comment should be fine. Since the target uses telpresence - I belive we are fairly sure that the operator is running locally. wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).