[PYTHON-2943] : Add socks5 proxy support #2040
Conversation
zaif-yuval
force-pushed
the
feature/socks5-proxy-support
branch
from
5a132e7 to
768bf17
Compare
zaif-yuval
force-pushed
the
feature/socks5-proxy-support
branch
from
768bf17 to
4682dac
Compare
zaif-yuval
changed the title
pymongo/client_options.py
Outdated
| @@ -170,6 +170,15 @@ def _parse_pool_options( | |||
| ssl_context, tls_allow_invalid_hostnames = _parse_ssl_options(options) | |||
| load_balanced = options.get("loadbalanced") | |||
| max_connecting = options.get("maxconnecting", common.MAX_CONNECTING) | |||
| if proxy_host := options.get("proxyHost"): | |||
| proxy = { | |||
There was a problem hiding this comment.
proxy seems like a boolean name, can we please rename to something like proxy_options?
pymongo/asynchronous/pool.py
Outdated
| if Proxy is None: | ||
| raise RuntimeError( | ||
| "In order to use SOCKS5 proxy, python_socks must be installed. " | ||
| "This can be done by re-installing pymongo with `pip install pymongo[socks]`" |
There was a problem hiding this comment.
I think we should be more generic and say pymongo[proxy] in case we switch to a different underlying library in the future.
|
The required tests are specified here. If you'd like to try running everything locally, I'd suggest something like the following: git clone https://github.com/mongodb-labs/drivers-evergreen-tools
cd drivers-evergreen-tools
bash .evergreen/setup.sh # create a standalone cli for https://github.com/mongodb-labs/drivers-evergreen-tools/blob/master/.evergreen/socks5srv.py
make run-server # start a server on 27017
./evergreen/socks5srv # run the cliOnce you have the tests working locally, I can either help walk through the Evergreen Configuration portion, or just make commits to your branch if you prefer. |
I'm not sure how to add the tests to work with proxy on your environment |
No description provided.