Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-39164: Flutter: Change baseURL during runtime #3239

Merged
merged 3 commits into from
May 6, 2024

Conversation

cbullinger
Copy link
Collaborator

@cbullinger cbullinger commented May 2, 2024

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-39164

  • Connect to App Services - Flutter SDK: New "Connect to a Specific Server" section with baseURL info. New "Connect to a Different Server During Runtime" subsection with info about the experimental API.

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Did you tag pages appropriately?
    • genre
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for related docs-app-services work, if any

Release Notes

  • Flutter SDK
    • Atlas App Services/Connect to App Services: New "Connect to a Specific Server" section with baseURL info. New "Connect to a Different Server During Runtime" subsection with info about the experimental API.

Review Guidelines

REVIEWING.md

Copy link

github-actions bot commented May 2, 2024

Readability for Commit Hash: 0509f70

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/flutter/app-services/connect-to-app: Grade Level: 7.2, Reading Ease: 66.74

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

@cbullinger cbullinger force-pushed the docsp-39164-flutter-baseurl branch from a27b2f1 to 29d9e28 Compare May 4, 2024 15:42
@cbullinger cbullinger marked this pull request as ready for review May 4, 2024 15:43
Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if you take either of my suggestions from the Kotlin PR, we might apply the same things here.

@cbullinger cbullinger merged commit ee4b327 into mongodb:master May 6, 2024
6 checks passed
@cbullinger cbullinger deleted the docsp-39164-flutter-baseurl branch May 6, 2024 16:40
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants