-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-33540): React Native: Update Connect to an App Services App with auth hooks #3176
Conversation
Readability for Commit Hash: c344421 You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor suggestion. LGTM! Thank you, Dachary!
const loggedInUserText = await screen.findByTestId('logged-in-user-id'); | ||
expect(loggedInUserText).not.toEqual(null); | ||
|
||
const notYetLoggedIn = screen.queryByText('No one is logged in yet.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I wish we could use the findBy*
for everything because we can await
results, but as you probably noticed, you can't test a negative with them. If findBy*
doesn't find what it wants, it errors the whole test. 😢
This does mean there could be edge cases where queryByText
isn't in sync with the rendered UI (because it's not waiting to find UI elements). But this is a great use for it.
source/sdk/react-native/app-services/connect-to-app-services-app.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: Kyle Rollins <[email protected]>
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/realm/master/ 🪵 Logs |
Pull Request Info
Note for reviewer: the tests are failing due to a known issue when you run all the tests in this test suite. I ran the new test here many times locally and it is passing.
Jira ticket: https://jira.mongodb.org/browse/DOCSP-33540
useApp
example to remove old auth pattern.Reminder Checklist
Before merging your PR, make sure to check a few things.
Release Notes
useApp
example to remove old auth pattern.Review Guidelines
REVIEWING.md