Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-43465) Incorrect information about Trigger changestream behavior in relation to Atlas clusters #861

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

amalhotra-mdb
Copy link
Collaborator

@amalhotra-mdb amalhotra-mdb commented Oct 3, 2024

Pull Request Info

Our Triggers docs have the following note about database triggers:

"Your app opens a single change stream for each collection with at least one enabled trigger. If multiple triggers are enabled for a collection they all share the same change stream."

This is not correct. We actually go in almost the opposite direction. We open a single changestream per database trigger. I am concerned it is leading some misunderstandings of the load that Triggers can put on a customer's cluster(s)

Jira ticket: https://jira.mongodb.org/browse/DOCSP-43465

Staging Links

  • triggers/database-triggers
  • Reminder Checklist

    Before merging your PR, make sure to check a few things.

    • Did you tag pages appropriately?
      • genre
      • programming_language
      • meta.keywords
      • meta.description
    • Describe your PR's changes in the Release Notes section
    • Create a Jira ticket for related docs-realm work, if any

    Release Notes

    Review Guidelines

    REVIEWING.md

    Copy link

    netlify bot commented Oct 3, 2024

    Deploy Preview for app-services ready!

    Name Link
    🔨 Latest commit f059494
    🔍 Latest deploy log https://app.netlify.com/sites/app-services/deploys/66ff07e951a9eb000816a123
    😎 Deploy Preview https://deploy-preview-861--app-services.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.
    Lighthouse
    Lighthouse
    1 paths audited
    Performance: 28 (🔴 down 17 from production)
    Accessibility: 85 (no change from production)
    Best Practices: 75 (no change from production)
    SEO: 77 (no change from production)
    PWA: -
    View the detailed breakdown and full score reports

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @MongoCaleb MongoCaleb left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @amalhotra-mdb amalhotra-mdb merged commit f0080e2 into mongodb:master Oct 3, 2024
    8 checks passed
    @amalhotra-mdb amalhotra-mdb deleted the DOCSP-43465 branch October 3, 2024 21:28
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants